200 so3 boot is blocking on rpi4 64bits #205
Open
+34
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemdiep
requested changes
Sep 30, 2025
so3/arch/arm64/mmu.c
Outdated
Comment on lines
678
to
683
| __sys_idmap_l1pgtable[l1pte_index(CONFIG_UART_LL_PADDR)] = CONFIG_UART_LL_PADDR & TTB_L1_BLOCK_ADDR_MASK; | ||
| set_pte_block(&__sys_idmap_l1pgtable[l1pte_index(CONFIG_UART_LL_PADDR)], DCACHE_OFF); | ||
| __sys_idmap_l1pgtable[l1pte_index(CONFIG_UART_LL_PADDR)] = CONFIG_UART_LL_PADDR & TTB_L1_BLOCK_ADDR_MASK; | ||
| set_pte_block(&__sys_idmap_l1pgtable[l1pte_index(CONFIG_UART_LL_PADDR)], DCACHE_OFF); |
There was a problem hiding this comment.
I think clang-format isn't liking that change, as it is whitespace only, easy fix would be to revert.
That function indentation is a bit weird because of the #ifdef CONFIG_AVZ which can add or not one level of indentation. So another possible fix would be to correct indentation for the function and add /* clang-format off */ and /* clang-format on */ arround of the function, so clang-format doesn't complain about it.
so3/mm/memory.c
Outdated
| #ifndef CONFIG_AVZ | ||
| __fdt_addr = (void *) __va(fdt_paddr); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Also remove this line for clang-format. (no empty line at the end of a function)
There was a problem hiding this comment.
@clemdiep Fine, I disabled clang-format in mmu.c
added 3 commits
October 7, 2025 09:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the correct PR